Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(CRaterRequest): Create AbstractCRaterRequest #289

Open
wants to merge 1 commit into
base: issue-286-allow-requests-to-berkeley-endpoint
Choose a base branch
from
Open

refactor(CRaterRequest): Create AbstractCRaterRequest #289

wants to merge 1 commit into from
+31 −43

Conversation

Aaron-Detre
Copy link

@Aaron-Detre Aaron-Detre commented Feb 12, 2025 •
edited
Loading

Changes

  • Moved duplicate code from CRaterScoringRequest and CRaterVerificationRequest into new AbstractCRaterRequest.

Test

  • Make sure that CRater scoring requests (dialog guidance) and CRater verification requests (open response, enable CRater) still work.

Closes #285

@Aaron-Detre Aaron-Detre changed the base branch from develop to issue-286-allow-requests-to-berkeley-endpoint February 12, 2025 22:07
@Aaron-Detre Aaron-Detre self-assigned this Feb 13, 2025
@Aaron-Detre Aaron-Detre added the enhancement New feature or request label Feb 13, 2025
@Aaron-Detre Aaron-Detre marked this pull request as ready for review February 13, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirokiterashima hirokiterashima Awaiting requested review from hirokiterashima

Assignees

@Aaron-Detre Aaron-Detre

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Aaron-Detre