Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Uncaught TypeError: dismissBtn is null #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Uncaught TypeError: dismissBtn is null #19

wants to merge 2 commits into from

Conversation

BrianHenryIE
Copy link

I'm sometimes getting

Uncaught TypeError: dismissBtn is null

This checks the result of document.querySelector before adding the handler.

@tylercollier
Copy link

tylercollier commented Jun 1, 2024 •
edited
Loading

Would someone please merge this (and cut a new version on packagist)?

aristath
aristath requested changes Jul 24, 2024
View reviewed changes
src/Dismiss.php Outdated Show resolved Hide resolved
@BrianHenryIE @aristath
Update src/Dismiss.php
96dd060 
Co-authored-by: Ari Stathopoulos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristath aristath aristath requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrianHenryIE @tylercollier @aristath