Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CourseCard Link in CourseList component #119

Merged
merged 2 commits into from
Jan 14, 2024
Merged

feat: add CourseCard Link in CourseList component #119

merged 2 commits into from
Jan 14, 2024

Conversation

22Xy
Copy link
Member

@22Xy 22Xy commented Jan 13, 2024

image
  • Add REACT_APP_API_URL in build script for a local working preview build.

add REACT_APP_API_URL in build script
Copy link

vercel bot commented Jan 13, 2024

@yzhxxyz is attempting to deploy a commit to the WTF Team on Vercel.

A member of the Team first needs to authorize it.

@22Xy 22Xy marked this pull request as draft January 13, 2024 23:12
@22Xy 22Xy marked this pull request as ready for review January 13, 2024 23:12
@22Xy
Copy link
Member Author

22Xy commented Jan 13, 2024

@AmazingAng @chongqiangchen could you review this pull request? Thank you!

@chongqiangchen
Copy link
Collaborator

chongqiangchen commented Jan 14, 2024

  1. 我push了一个.env.sample和增加了cp .env.sample .env的提示帮助本地项目的运行,替代了Add REACT_APP_API_URL in build script for a local working preview build这个需求,因为线上由vercel env增加的环境值
  2. Link to的链接可能是外部链接(https://xxxx.com/course_path),这也是当时开发者这样写的原因, 可能需要调整一下,格式化routepath后给到link to合适一些

Copy link

vercel bot commented Jan 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2024 8:47am

@22Xy
Copy link
Member Author

22Xy commented Jan 14, 2024

  1. 我push了一个.env.sample和增加了cp .env.sample .env的提示帮助本地项目的运行,替代了Add REACT_APP_API_URL in build script for a local working preview build这个需求,因为线上由vercel env增加的环境值

  2. Link to的链接可能是外部链接(https://xxxx.com/course_path),这也是当时开发者这样写的原因, 可能需要调整一下,格式化routepath后给到link to合适一些

好的我修改一下👌🏼

@22Xy
Copy link
Member Author

22Xy commented Jan 14, 2024

根据@chongqiangchen 建议修改了一下代码:7ed803d

内部路径:
image

外部链接:
image

删除了build script中的 REACT_APP_API_URL

@chongqiangchen chongqiangchen merged commit 89f899d into WTFAcademy:main Jan 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants