Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only display year selector when Datepicker shows months only #2368

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

simon-hv
Copy link
Contributor

Fixes #2366

@simon-hv simon-hv requested a review from a team as a code owner November 27, 2023 16:49
Copy link

👀 Visit Preview

width: 4rem;
height: 2rem;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this to improve the style when we display months:

Before

Screenshot 2023-11-27 at 17 53 37

After

Screenshot 2023-11-27 at 17 53 19

packages/DateTimePickerCommon/src/CustomHeader.tsx Outdated Show resolved Hide resolved
packages/DateTimePickerCommon/src/CustomHeader.tsx Outdated Show resolved Hide resolved
@simon-hv simon-hv force-pushed the fix-datepicker-years-only-header-2366 branch from 537fe02 to 655a33d Compare December 11, 2023 10:07
@theo-mesnil theo-mesnil merged commit f112919 into master Dec 11, 2023
2 checks passed
@theo-mesnil theo-mesnil deleted the fix-datepicker-years-only-header-2366 branch December 11, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A Datepicker that only displays months should have a different custom header
2 participants