simplified value update logic

War-Brokers-Mods · Mar 9, 2022 · 0f18ff8 · 0f18ff8
1 parent 5f4e856
commit 0f18ff8
Showing 1 changed file with 14 additions and 22 deletions.
diff --git a/Elo.html b/Elo.html
@@ -22,6 +22,7 @@
       referrerpolicy="no-referrer"
       type="module"
     ></script>
+
     <style>
       :root {
         --width: 325px;
@@ -218,34 +219,25 @@
 
       socket.onmessage = (event) => {
         let data = JSON.parse(event.data);
+        let playerStat = data.playerStatsArray[data.localPlayerIndex];
 
-        if (data.playerStatsArray[data.localPlayerIndex].killsEloDelta < 0) {
-          killsEloDelta.classList.remove("positive");
-        } else {
+        killsEloCountUp.update(playerStat.killsElo);
+        killsEloDeltaCountUp.update(playerStat.killsEloDelta / 10);
+
+        gamesEloCountUp.update(playerStat.gamesElo);
+        gamesEloDeltaCountUp.update(playerStat.gamesEloDelta / 10);
+
+        if (playerStat.killsEloDelta >= 0) {
           killsEloDelta.classList.add("positive");
+        } else {
+          killsEloDelta.classList.remove("positive");
         }
 
-        if (data.playerStatsArray[data.localPlayerIndex].gamesEloDelta < 0) {
-          gamesEloDelta.classList.remove("positive");
-        } else {
+        if (playerStat.gamesEloDelta >= 0) {
           gamesEloDelta.classList.add("positive");
+        } else {
+          gamesEloDelta.classList.remove("positive");
         }
-
-        killsEloCountUp.update(
-          data.playerStatsArray[data.localPlayerIndex].killsElo
-        );
-
-        killsEloDeltaCountUp.update(
-          data.playerStatsArray[data.localPlayerIndex].killsEloDelta / 10
-        );
-
-        gamesEloCountUp.update(
-          data.playerStatsArray[data.localPlayerIndex].gamesElo
-        );
-
-        gamesEloDeltaCountUp.update(
-          data.playerStatsArray[data.localPlayerIndex].gamesEloDelta / 10
-        );
       };
     </script>
   </body>