Skip to content

Commit

Permalink
Memory64 spec tweaks and fixes from @rossberg (#98)
Browse files Browse the repository at this point in the history
- Removed unnecessary/mismatching lookup of table/memory type in execution prose
- Added missing result type lookup in formal rule for table.size and memory.size
- Fixed computation of -1 result value for table.grow and table.size to work for i64
- Some fixes around specification of text format for inline elements/data shorthand
- Fixed matching rules for tabletype/memtype to enforce same address type

Split out from WebAssembly#1839
  • Loading branch information
sbc100 authored Nov 6, 2024
1 parent ed1fc53 commit ace0947
Show file tree
Hide file tree
Showing 6 changed files with 217 additions and 267 deletions.
6 changes: 3 additions & 3 deletions document/core/binary/types.rst
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ Additional shorthands are recognized for unary recursions and sub types without
Limits
~~~~~~

:ref:`Limits <syntax-limits>` are encoded with a preceding flag indicating whether a maximum is present, and the corresponding :ref:`address type <syntax-addrtype>`.
:ref:`Limits <syntax-limits>` are encoded with a preceding flag indicating whether a maximum is present, and a flag for the :ref:`address type <syntax-addrtype>`.

.. math::
\begin{array}{llclll}
Expand All @@ -275,7 +275,7 @@ Memory Types
.. math::
\begin{array}{llclll@{\qquad\qquad}l}
\production{memory type} & \Bmemtype &::=&
(\X{at}, \X{lim}){:}\Blimits &\Rightarrow& \X{at}~~\X{lim} \\
(\X{at},\X{lim}){:}\Blimits &\Rightarrow& \X{at}~\X{lim} \\
\end{array}
Expand All @@ -291,7 +291,7 @@ Table Types
.. math::
\begin{array}{llclll}
\production{table type} & \Btabletype &::=&
\X{et}{:}\Breftype~~(\X{at}, \X{lim}){:}\Blimits &\Rightarrow& \X{at}~~\X{lim}~\X{et} \\
\X{et}{:}\Breftype~~(\X{at},\X{lim}){:}\Blimits &\Rightarrow& \X{at}~\X{lim}~\X{et} \\
\end{array}
Expand Down
Loading

0 comments on commit ace0947

Please sign in to comment.