Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outline start function instructions #100

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Outline start function instructions #100

merged 2 commits into from
Jun 5, 2024

Conversation

rossberg
Copy link
Collaborator

@rossberg rossberg commented Jun 4, 2024

This change triggers another error from the interpreter:

9-module.watsup:152.50-152.76: interpreter error: instantiate: ?() is not a Wasm value (interpreting PushI (IterE (VarE (instr_S), [instr_S], ?)))

@ShinWonho, can you please have a look?

@rossberg rossberg requested a review from ShinWonho June 4, 2024 09:54
@ShinWonho
Copy link

Similarly with #98, translating rhs expression IterE with Opt was not general enough. Now I have generalized it!

@rossberg
Copy link
Collaborator Author

rossberg commented Jun 5, 2024

Thanks!

@rossberg rossberg merged commit c0a1763 into main Jun 5, 2024
5 checks passed
@rossberg rossberg deleted the bug.start branch June 5, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShinWonho ShinWonho Awaiting requested review from ShinWonho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rossberg @ShinWonho