Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate runtime type checks #101

Merged
merged 14 commits into from
Jul 23, 2024
Merged

Activate runtime type checks #101

merged 14 commits into from
Jul 23, 2024

Conversation

rossberg
Copy link
Collaborator

@rossberg rossberg commented Jun 4, 2024

This PR adds previously missing runtime type checks on the arguments to the instantiate and invoke meta functions. The interpreter cannot currently handle these and will probably need some manual exemptions.

@ShinWonho, can you please look into this? To at least get the spec document correct quickly, perhaps the simplest temporary fix is to somehow just ignore these premises in the interpreter backend.

@rossberg rossberg requested a review from ShinWonho June 4, 2024 10:01
@presenthee
Copy link
Collaborator

@ShinWonho and I made some changes for the temporary fix:

  • Removed the animate option
  • Handled rule premises based on suffix matching
    rule _ok and _const are translated into AssertI. Currently, assertions are not working in the interpreter (thus they are ignored now) and we will revisit this after implementing assertions in the interpreter.

@rossberg rossberg merged commit 88e8450 into main Jul 23, 2024
5 checks passed
@rossberg rossberg deleted the bug.invoke-typechecks branch July 23, 2024 06:52
@rossberg
Copy link
Collaborator Author

Thanks @presenthee & @ShinWonho!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants