Append source region for AL algorithms #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossberg
reviewed
Jul 15, 2024
| if List.length args <> List.length params then | ||
| raise (Exception.InvalidArg ("Args number mismatch for algorithm " ^ name)); | ||
| if List.length args <> List.length params then ( | ||
| raise (Exception.InvalidArg ( |
There was a problem hiding this comment.
Looks good, but can we report this message using the existing infrastructure in the util/error module, such that the region is shown in the standard manner?
There was a problem hiding this comment.
Yes, it seems that a tailored wrapper function for the error handling used no_region by default, and therefore the region was not printed.
For this specific case, instead of using wrapper, now it's directly printed in the following standard format:
spec/wasm-2.0/8-reduction.watsup:201.1-207.50: interpreter error: Expected 4 arguments for the algorithm `CVTOP` but 3 arguments are given (interpreting (CVTOP I64 I64 (EXTEND S)))
We would need to refactor the error message for other cases as well, but perhaps in a separate commit.
rossberg
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR appends the source region for AL
algorithms,useful for creating better error messages by explicitly denoting which part of the spec files is converted in to the given algorithm.