Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that variables in rules and defs are bound #44

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

rossberg
Copy link
Collaborator

@rossberg rossberg commented Nov 3, 2023

This uncovered a couple more bugs in the spec (and some more on the wasm3 branch).

@rossberg rossberg requested a review from f52985 November 3, 2023 09:36
Copy link
Collaborator

@f52985 f52985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

It's kinda interesting that similar assumptions for pat_exp were made (especially, treating last position of a call as a pattern) when animating the premises.

@rossberg
Copy link
Collaborator Author

rossberg commented Nov 3, 2023

Probably not a coincidence. Although it would be cleaner if we had more explicit rules, e.g., distinguishing let bindings from random equations, mark relation parameters as input vs output, and mark function parameters as invertible.

@rossberg rossberg merged commit d6cc096 into main Nov 3, 2023
1 check passed
@rossberg rossberg deleted the binding-check branch November 3, 2023 13:46
rossberg added a commit that referenced this pull request Mar 7, 2024
Rename new traps.wast test -> traps0.wast
Alan-Liang added a commit to Alan-Liang/spectec that referenced this pull request Sep 1, 2024
…sm-DSL#44)

* [spec] resume_throw should accept multiple handlers (Wasm-DSL#71)

* Add missing *

---------

Co-authored-by: Alan L <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants