forked from WebAssembly/spec
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error messages from backends #86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossberg
reviewed
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I added a few comments where the message possibly is rather opaque for end users.
rossberg
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Alan-Liang
pushed a commit
to Alan-Liang/spectec
that referenced
this pull request
Oct 3, 2024
* Revert "Allow cont ref to be non-null in switch (Wasm-DSL#85)" This reverts commit 92cbcc5. * Remove other unnecessary `null?` in instruction typing
rossberg
pushed a commit
that referenced
this pull request
Nov 7, 2024
* Rework IndexValueToU64 to allow more inputs to BigInts * Address #86 feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles #73.
Main Changes:
Source.error
functions toutil/error.ml
.al_util
.failwith
in backends. UseError.error
if possible.Changes specific to the backend-interpreter:
For AL-level debugging, new exceptions were added.
Backend_interpreter.Exception.Error
is raised when there is an exception while stepping an instruction. (bytry_step_wasm
,try_step_instr
)Backend_interpreter.Exception.Error
contains step(instruction), line and al function name information. These are printed with the original exception message.