Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Add getBytes() method to PlatformFile #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vinceglb
Copy link
Collaborator

@vinceglb vinceglb commented Jan 24, 2024

I added back the useful method getBytes() that was here before to PlatFormFile with the exact same logic as before, except for Android where I added the fix from @shubhamsinghshubham777 proposed in this PR #104 that fixes #107

@shalva97
Copy link
Collaborator

Do you want to be a maintainer? I will ask @Wavesonics, he usually responds on Kotlin's Slack

Personally I dont use this library, there was just my pet project, which used it but I have abandoned that.

@vinceglb
Copy link
Collaborator Author

vinceglb commented Feb 6, 2024

I thought about it and I'm really interested!

I'm motivated to help this project grow. It will be my first time as a maintainer. I think I'll need a bit of guidance at first.

Some of the questions I have:

  • What are your expectations of me?
  • What are my obligations?

@shalva97
Copy link
Collaborator

shalva97 commented Feb 7, 2024

That's great 🚀

Are you on Kotlin's Slack? we could disscus it there

@vinceglb
Copy link
Collaborator Author

vinceglb commented Feb 8, 2024

Yes! My name on Kotlin Slack is Vincent Guillebaud

@c4software
Copy link

Any news about merging this PR ?

@vinceglb vinceglb requested a review from santiwanti March 6, 2024 09:24
@vinceglb vinceglb self-assigned this Mar 6, 2024
Copy link
Collaborator

@santiwanti santiwanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinceglb this looks good to me. I have actually been waiting for this to be merged before merging #100 as was mentioned in Slack (it might have happened before you joined), I didn't realize you were waiting on my review.

Is removing the strict visibility modifiers i.e. removing public something that was talked about? I don't personally mind and this was done before I joined, but it was obviously added explicitly.

@vinceglb
Copy link
Collaborator Author

The public keyword adds a lot of warnings in the IDE since it's a "Redundant visibility modifier". So I decided to remove it.

CleanShot 2024-03-27 at 13 58 58@2x

By default, everything is public. If we want to keep something internal to the module, we can explicitly use the internal keyword. But the public keyword is redundant by default.

@santiwanti
Copy link
Collaborator

There is a setting to set explicit visibility modifiers which means that public has to be specified explicitly. I think that was set previously. maybe it was removed in which case we can remove the public modifier

@shalva97
Copy link
Collaborator

Usually it is a good practice to have them explicitly specified for libraries. There was explicitApi() call in Gradle file but seems to be removed in the below commit, so now IDE thinks those visibility modifiers are not needed. Here is a video for more info https://www.youtube.com/watch?v=IsXra6RvkI0

ff5753a#diff-03ca1f7f69c9e33ebd830ae945f65c9fc879e6c2a296cedaf77e2a02e009f880

I think it should be added back

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception on Android
4 participants