Improve SimpleJob docs regarding attribute changes #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioperrella
force-pushed
the
improve-readme
branch
2 times, most recently
from
140d70f
to
81b0915
Compare
fabioperrella
force-pushed
the
improve-readme
branch
from
81b0915
to
10be7bc
Compare
fabioperrella
changed the title
fabioperrella
requested review from
martijnvermaat,
julik,
lorenzograndi4,
linkyndy and
nitika080289
lorenzograndi4
approved these changes
Dec 15, 2020
martijnvermaat
approved these changes
Dec 17, 2020
Co-authored-by: Martijn Vermaat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #66 (comment)
When adding or removing an attribute from a job class, it's necessary to create a new one.
This PR improves the documentation to warn about it.