Add thread.spawn_indirect
#447
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change codifies the conclusions we arrived to in [WebAssembly#89]. It adds a new way to spawn threads, `thread.spawn_indirect`, which retrieves the thread start function from a table. This prompted me to rename `thread.spawn` to `thread.spawn_ref`. [WebAssembly#89]: WebAssembly/shared-everything-threads#89
abrown
commented
Feb 7, 2025
Comment on lines
+3818
to
+3820
| * `$ft` must refer to a `shared` function type; initially, only the type `(func | ||
| shared (param $c i32))` is allowed (see explanation in `thread.spawn_ref` | ||
| above) |
There was a problem hiding this comment.
What I can't remember well is whether we truly need $ft in the definition. I left it in for now, but it would seem that without it we can still statically verify from the type of $t that the table elements are in fact shared function references.
There was a problem hiding this comment.
Implementation-wise it is $ft that is problematic currently, so at least temporarily it isn't too useful anyways seeing as we must fix the start function to only [i32] -> [].
abrown
added a commit
to abrown/wasm-tools
that referenced
this pull request
Feb 7, 2025
This encoding change is necessary due to recent additions to the component model; see [bytecodealliance#447]. [bytecodealliance#447]: WebAssembly/component-model#447
abrown
added a commit
to abrown/wasm-tools
that referenced
this pull request
Feb 7, 2025
[bytecodealliance#447] tries to make the built-in naming a bit more consistent; this change propagates that here. [bytecodealliance#447]: WebAssembly/component-model#447
abrown
added a commit
to abrown/wasm-tools
that referenced
this pull request
Feb 7, 2025
This encoding change is necessary due to recent additions to the component model; see [bytecodealliance#447]. [bytecodealliance#447]: WebAssembly/component-model#447
abrown
added a commit
to abrown/wasm-tools
that referenced
this pull request
Feb 7, 2025
[bytecodealliance#447] tries to make the built-in naming a bit more consistent; this change propagates that here. [bytecodealliance#447]: WebAssembly/component-model#447
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change codifies the conclusions we arrived to in #89. It adds a new way to spawn threads,
thread.spawn_indirect, which retrieves the thread start function from a table. This prompted me to renamethread.spawntothread.spawn_ref.