Test return_call*s to callees that return more values than the caller does
#116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er does While a `call $f; return` sequence where `$f` returns more values than its caller is valid so long as the tail of `$f`'s returns match the caller's returns, however that situation is not valid for `return_call $f`. Tail callees must return the exact same number of results as the caller, not more. This case was not previously exercised in any of the spec tests. Procedural note: I am adding all these tests to the function-references proposal to avoid needing to make multiple PRs to multiple repos because `return_call_ref` was not introduced until this proposal.
rossberg
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While a
call $f; returnsequence where$freturns more values than its caller is valid so long as the tail of$f's returns match the caller's returns, however that situation is not valid forreturn_call $f. Tail callees must return the exact same number of results as the caller, not more. This case was not previously exercised in any of the spec tests.Procedural note: I am adding all these tests to the function-references proposal to avoid needing to make multiple PRs to multiple repos because
return_call_refwas not introduced until this proposal.@rossberg PTAL