Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ADAPTER_URL to reference v29.0.1 #575

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

mcbarton
Copy link
Contributor

@mcbarton mcbarton commented Feb 4, 2025

This PR updates ADAPTER_URL to reference the latest release version (versions 29.0.1)

@mcbarton
Copy link
Contributor Author

mcbarton commented Feb 4, 2025

@alexcrichton @sbc100 pinging for review

Copy link
Collaborator

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, on second thought, I wonder what you're trying to accomplish here? Were you seeing some kind of issue or just updating as a best practice? There's a Wasmtime version a few lines up that you might want to change as well. (And we could create an extra variable to control both or something like that, but I'm not too worried about that).

[edit: never mind I see the other PR doing that now!]

@abrown abrown merged commit 525bb2e into WebAssembly:main Feb 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants