-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node status for GC #369
Conversation
So this does match a V8 update to v11.9 in node (which matches Chrome 119 where this feature turned on by default), but it seems odd that the error you're getting is related to stringref rather than GC, because it's not obvious to me where a stringref would be coming from here. Maybe @tlively has a clue? |
From conversation with @titzer, it seems like the reason the error mentions stringref is that the opcodes were changed, so the new opcode for something in this |
Aha yes I forgot about that, that explains it. Yeah because of the opcode change we maybe shouldn't say that versions older than the nightly even have GC support, since the tools are now all emitting the new opcodes by default, and those binaries won't work at all on the older versions (even with the flag). |
@dschuff Sounds good, done! |
Just to confirm what you've already figured out:
So, in summary, I think it's fair to say that Node 22 supports WasmGC without flags, and for any earlier Node version WasmGC is effectively impossible to use (even with flags, due to the binary encoding difference). |
Thanks, to both of you! |
Using Binaryen v116, assemble
pairs.wat
via this command:
Then download the Node nightlies from Jan 4 and Jan 5:
And with each of those nightlies, try to run
pairs.js
via this command:
The Jan 5 nightly prints
2
to the console as expected, while the Jan 4 nightly instead gives this error message: