Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove options from processor of Bitcrusher example #2492

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

chrisguttandin
Copy link
Contributor

@chrisguttandin chrisguttandin commented May 23, 2022

This PR is intended to fix #2491.


Preview | Diff

@hoch hoch self-requested a review June 2, 2022 16:20
@chrisguttandin
Copy link
Contributor Author

Hi @hoch, thanks for the approval. However it looks like I can't merge the PR myself. GitHub only allows me to close it.

@padenot
Copy link
Member

padenot commented Jun 3, 2022

Yes, we need to rework you PR to add the necessary markup for change tracking vs. the Recommendation, so it looks like this in the end: https://webaudio.github.io/web-audio-api/#c2359.

@orottier
Copy link

Hi, I just wanted to say this has caused some confusion on our side as well so it would be good to have this merged.
I could have a look at the markup if desired.

@hoch
Copy link
Member

hoch commented May 30, 2024

@svgeesus This change is within the code example, which I believe "non-normative". Do we need the Proposed Correction mark up for this?

@hoch
Copy link
Member

hoch commented Jul 16, 2024

The GItHub's web editor doesn't seem to be handling tab/space indentation very well. We might need some manual labor on this.

That said, I believe this is purely editorial and non-normative, so we can merge this without PC markups.

@chrisguttandin
Copy link
Contributor Author

@hoch I will rebase the changes manually.

@hoch hoch merged commit 89b51b1 into WebAudio:main Jul 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AudioWorkletProcessor in Bitcrusher example calls super() with options
5 participants