Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'settings' directory which includes 'settings.py' file #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gb0101010101
Copy link
Contributor

This file and directory do not appear to be used anymore. They look to have been replaced by 'config/config.py' using 'defaultwebcontrol.json' and 'webcontrol.json'.

Searched code for:

  • Imports from 'settings'
  • Usage of 'setting' functions

Tested:

  • All WebControl settings pages
  • Running gcode using fakeservo

No errors reported and everything worked.
Think it is safe to delete this.

…ry which includes 'settings.py' file. This does not appear to be used anymore and has been replaced by 'config/config.py' using 'defaultwebcontrol.json' and 'webcontrol.json'.
@gb0101010101
Copy link
Contributor Author

Can anyone confirm these files are no longer used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant