add support to Log Message breakpoint #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool! can you add a sample, maybe a sample screenshot/gif in the README or other docs file to show off this feature? |
WebFreak001
reviewed
May 29, 2024
| const matches = this.logMsgVar.match(this.logReplaceTest); | ||
| const count = matches ? matches.length : 0; | ||
| this.logMsgRplNum = count; | ||
| this.logMsgVarProcess = this.logMsgVar.replace(this.logReplaceTest, "placeHolderForVariable"); |
There was a problem hiding this comment.
I'm not a huge fan of the magic string here and would much prefer if we could instead maybe split by the regex, so it's not possible to have this value accidentally in the output message (even if very unlikely)
|
btw you can just push to the |
2. add logMessage in README.
thank you. i fix the lint error, add a gif in readme |
WebFreak001
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#426 @WebFreak001, thanks for your advice, i modified the code, makes LogMessage var and function in a class.