prevent error in evaluateRequest when a variable is not found #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should definitely be disabled for 'hover' but the 'watch' context shows the error not in a message box but in the variable "output", no? |
oltolm
force-pushed
the
evaluateRequest_fix
branch
2 times, most recently
from
3129469
to
86d4166
Compare
|
I changed it to only send an error in the |
GitMensch
requested changes
Sep 14, 2024
There was a problem hiding this comment.
That's a good direction.
Please swap the check testing for hover as this makes it more clear that we don't want an error for this case, an additional comment like "suppress error for hover as the user may just play with the mouse" would be good, too.
Add a Changelog entry and that's good for merge.
oltolm
force-pushed
the
evaluateRequest_fix
branch
from
86d4166
to
8403fb5
Compare
|
Done. Please release a new version. I fixed a severe bug 6 months ago and it is still not in a released version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the error message when a variable can not be found. Fixes #429.