Sampler filter #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 24, 2015 16:52
…d texture. Generated mipmap for texture. Added cleanup code. Added animationFrame
… only instead of each new unit
trungtle
force-pushed
the
tle/sampler_filter
branch
from
6548d04
to
801fe2c
Compare
trungtle
force-pushed
the
tle/sampler_filter
branch
from
801fe2c
to
9ddb18e
Compare
|
@pjcozzi Ready to merge |
Merged
|
@shrekshao could you check this one actually |
added 8 commits
December 30, 2015 14:25
trungtle
force-pushed
the
tle/sampler_filter
branch
from
b5315f9
to
63a9456
Compare
|
@pjcozzi Should be ready now |
|
Made some style tweaks in f986ade. I'll comment on a few lines of interest. |
| <html lang="en"> | ||
|
|
||
| <head> | ||
| <title>WebGL 2 Samples - sampler_filter</title> |
There was a problem hiding this comment.
Always use "WebGL", not "webgl."
| <div id="info">WebGL 2 Samples - sampler_filter</div> | ||
|
|
||
| <script id="vs" type="x-shader/x-vertex"> | ||
| #version 300 es |
There was a problem hiding this comment.
A while back I changed the helper function so #version can be on a new line like this instead of on the same line as the script tag.
|
Just those comments. This looks really good, and is close to being ready. |
|
Thanks @pjcozzi ! Going to fix these now |
|
@pjcozzi I went through the comments and updated with very small tweaks. |
|
This is a masterpiece. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sample showcase different filters for samplers