Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CESR 2.0 code tables to match keripy #161

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

daidoji
Copy link
Collaborator

@daidoji daidoji commented Dec 1, 2023

Rationale

Starting work on upgrading CESR to 2.0 version as detailed in #160

Testing

Updated naive code table tests but that's about it. Still have questions about how cesride was tested against keripy in #cesr channel on discord.

For Reviewers

  • Verify version bumped in Cargo.toml

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7cd5453) 95.42% compared to head (336469d) 95.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   95.42%   95.47%   +0.04%     
==========================================
  Files          32       32              
  Lines        3037     3069      +32     
==========================================
+ Hits         2898     2930      +32     
  Misses        139      139              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daidoji daidoji changed the title WARNING: Doesn't pass tests, may not build Updated CESR 2.0 code tables to match keripy Dec 6, 2023
@daidoji daidoji marked this pull request as ready for review December 6, 2023 15:07
@daidoji
Copy link
Collaborator Author

daidoji commented Dec 7, 2023

Changing to draft, this work is on hold until Sam completes work. WebOfTrust/cesr-ts#17 (comment)

@daidoji daidoji marked this pull request as draft December 7, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant