Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(effects): added campfire effects #79

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

finger563
Copy link
Member

Description

  • Created campfire niagara particle system
  • Added campfire particle system to campfire in diorama test scene
  • Updated campfire material to point to new emissive texture which is just the orange colors from the texture map
  • Updated voxel subsurface (both textured and non-textured) to support highlight strength parameter.
  • Updated voxel subsurface material to allow for dynamic material parameters (used in niagara system for updating color) for the emissive color
  • Added some voxel subsurface material instances for the dirt, fire, grass, path, smoke, stone, and vine for use when blocking out levels (and maybe in the future when building levels in UE editor)
  • Updated diorama test scene to be at dusk for softer lighting and to show off particle effects and highlights more

Motivation and Context

Related to #37 we needed to start adding particle effects to the world to start building up some systems for use. This PR adds campfire (smoke + particles) using cube meshes (voxels) with new material instances for control and configuration from niagara particle system.

How has this been tested?

Playing the diorama test scene in the editor.

Screenshots (if appropriate):

wot_campfire_test_2.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Art / Asset
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Art / Asset Update
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Created campfire niagara particle system
* Added campfire particle system to campfire in diorama test scene
* Updated campfire material to point to new emissive texture which is just the orange colors from the texture map
* Updated voxel subsurface (both textured and non-textured) to support highlight strength parameter.
* Updated voxel subsurface material to allow for dynamic material parameters (used in niagara system for updating color) for the emissive color
* Added some voxel subsurface material instances for the dirt, fire, grass, path, smoke, stone, and vine for use when blocking out levels (and maybe in the future when building levels in UE editor)
* Updated diorama test scene to be at dusk for softer lighting and to show off particle effects and highlights more
@finger563 finger563 merged commit ef89cdb into main Aug 11, 2023
@finger563 finger563 deleted the feature/campfire-fx branch August 11, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant