fix: Do not connect to network on startup when setting is disabled #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. This setting originally just referred to telemetry but this should ultimately be handled somewhere higher up probably so all requests to the API are just rejected (or just turn off all networking stuff). I'll merge it for now though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
ImHex asks users whether they wish to opt-in to network connections on start (excellent!), then ignores that and tries to connect to the network anyway when the welcome screen loads (less excellent!).
Implementation description
Also don’t connect to the network on the welcome screen if it is supposed to not do that.