fix: F3 failed to locate the correct set of matches if file was edited after doing a search. #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d after doing a search. The bug can be reproduced as follows: 1) Using ctrl-F do a search for a term that occurs several times in the file. and press f3 to visit them. 2) go back to the fop of the file and insert 3 blank lines. 3) pressing f3 once or many times will not find the term entered above. The reason for this bug is that the positions of the matches are not being reset when changes can potentially move them. The fix consists on resetting the search locations when changing the contents of the file and redoing the search after the changes are made. The bug was specially problematic when doing replace because the replacement position would be identified as a match. This PR fixes replace as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
The bug can be reproduced as follows:
Implementation description
The reason for this bug is that the positions of the matches are not being reset when changes can potentially move them.
The fix consists on resetting the search locations when changing the contents of the file and redoing the search after the changes are made. The bug was specially problematic when doing replace because the replacement position would be identified as a match. This PR fixes replace as well.