Add MemorialViewSet and Remove MemorialModelAdmin #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @brylie - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| from .models import Memorial | ||
|
|
||
|
|
||
| class MemorialViewSet(PageListingViewSet): |
There was a problem hiding this comment.
suggestion: Definition of MemorialViewSet
Consider adding a docstring to the 'MemorialViewSet' class to provide a brief description of its purpose and functionality.
Suggested change
| class MemorialViewSet(PageListingViewSet): | |
| class MemorialViewSet(PageListingViewSet): | |
| """ | |
| A viewset for viewing and editing Memorial instances. | |
| """ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the
MemorialViewSetclass and removes theMemorialModelAdminclass. TheMemorialViewSetclass is responsible for handling the API endpoints and Wagtail UI elements related to memorials, while theMemorialModelAdminclass is no longer needed. This change improves the organization and functionality of the codebase.