Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize search result templates #1092

Merged
merged 6 commits into from
Jun 27, 2024
Merged

Conversation

brylie
Copy link
Member

@brylie brylie commented Jun 27, 2024

Closes #1066

Updates search result templates to follow a standardized format across the site.

  • Standardizes the HTML structure of search result templates to use a Bootstrap card body format, ensuring a consistent appearance and layout. This includes updating titles to use an H2 element with Bootstrap classes for a smaller heading appearance and wrapping titles in a card title link.
  • Removes the content type in parentheses next to the title across all search templates, aligning with the desired outcome for a cleaner and more uniform display of search results.
  • Adjusts the fallback display in search/templates/search/search.html for search results without a specific template to also use the Bootstrap card body format and removes the content type in parentheses next to the title, ensuring consistency even when a specific template is not available.
  • Maintains the functionality of the search feature in search/views.py, ensuring that the search results are correctly rendered using the updated templates without altering the core search functionality.

For more details, open the Copilot Workspace session.

Summary by Sourcery

This pull request standardizes the search result templates across the site by updating the HTML structure to use a Bootstrap card body format, ensuring consistent appearance and layout. It also removes the content type in parentheses next to the title for a cleaner display and maintains the core search functionality.

  • Enhancements:
    • Standardized the HTML structure of search result templates to use a Bootstrap card body format for consistent appearance and layout.
    • Updated titles in search result templates to use an H2 element with Bootstrap classes for a smaller heading appearance and wrapped titles in a card title link.
    • Removed the content type in parentheses next to the title across all search templates for a cleaner and more uniform display of search results.
    • Adjusted the fallback display in search/templates/search/search.html to use the Bootstrap card body format and removed the content type in parentheses next to the title.

Copy link
Contributor

sourcery-ai bot commented Jun 27, 2024

Reviewer's Guide by Sourcery

This pull request standardizes the HTML structure of search result templates across the site to use a Bootstrap card body format. It ensures a consistent appearance and layout by updating titles to use an H2 element with Bootstrap classes and wrapping titles in a card title link. Additionally, it removes the content type in parentheses next to the title across all search templates and adjusts the fallback display for search results without a specific template. The core search functionality in search/views.py remains unchanged.

File-Level Changes

Files Changes
search/templates/search/online_worship.html
search/templates/search/magazine_article.html
search/templates/search/community_directory.html
search/templates/search/event.html
search/templates/search/magazine_issue.html
search/templates/search/meeting.html
search/templates/search/organization.html
Standardized the HTML structure to use a Bootstrap card body format, updated titles to H2 elements with Bootstrap classes, and wrapped titles in card title links.
search/templates/search/search.html Adjusted fallback display to use Bootstrap card body format and removed content type in parentheses next to the title.
search/views.py Maintained core search functionality with a minor comment change.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @brylie - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 7 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

search/templates/search/online_worship.html Outdated Show resolved Hide resolved
search/templates/search/magazine_article.html Outdated Show resolved Hide resolved
search/templates/search/event.html Show resolved Hide resolved
search/templates/search/magazine_issue.html Outdated Show resolved Hide resolved
search/templates/search/meeting.html Show resolved Hide resolved
search/templates/search/organization.html Show resolved Hide resolved
Copy link

sonarcloud bot commented Jun 27, 2024

@brylie brylie merged commit 3643c5f into main Jun 27, 2024
6 checks passed
@brylie brylie deleted the brylie/standardize-search-templates branch June 27, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Results - Standardize Search Result Templates
1 participant