-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize search result templates #1092
Conversation
Reviewer's Guide by SourceryThis pull request standardizes the HTML structure of search result templates across the site to use a Bootstrap card body format. It ensures a consistent appearance and layout by updating titles to use an H2 element with Bootstrap classes and wrapping titles in a card title link. Additionally, it removes the content type in parentheses next to the title across all search templates and adjusts the fallback display for search results without a specific template. The core search functionality in File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @brylie - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 7 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Quality Gate passedIssues Measures |
Closes #1066
Updates search result templates to follow a standardized format across the site.
search/templates/search/search.html
for search results without a specific template to also use the Bootstrap card body format and removes the content type in parentheses next to the title, ensuring consistency even when a specific template is not available.search/views.py
, ensuring that the search results are correctly rendered using the updated templates without altering the core search functionality.For more details, open the Copilot Workspace session.
Summary by Sourcery
This pull request standardizes the search result templates across the site by updating the HTML structure to use a Bootstrap card body format, ensuring consistent appearance and layout. It also removes the content type in parentheses next to the title for a cleaner display and maintains the core search functionality.
search/templates/search/search.html
to use the Bootstrap card body format and removed the content type in parentheses next to the title.