Skip to content

Commit

Permalink
Merge pull request #311 from WestpacGEL/301-gel-docs-home-page-cant-c…
Browse files Browse the repository at this point in the history
…lose-the-main-menu-in-mobile

closes #301 gel docs home page cant close the main menu in mobile
  • Loading branch information
samithaf authored Nov 20, 2023
2 parents b0e1501 + cf6fc7e commit 2df41f7
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,23 @@ export function BrandSelect(props: BrandSelectProps) {
const { focusProps, isFocusVisible } = useFocusRing();
const styles = brandSelectStyles({ isFocusVisible, isOpen: state.isOpen });

const finalButtonProps = mergeProps(focusProps, buttonProps);
return (
<div className={styles.base()}>
<div {...labelProps} className={styles.label()}>
{props.label}
</div>

<button {...mergeProps(buttonProps, focusProps)} ref={ref} className={styles.button()}>
<button
{...finalButtonProps}
onClick={undefined}
onPointerUp={undefined}
onPointerDown={() => {
state.toggle();
}}
ref={ref}
className={styles.button()}
>
<div className={styles.textWrapper()}>
<div className="flex w-full items-end gap-[0.625rem] overflow-hidden text-ellipsis py-2" {...valueProps}>
<GELLogo className="w-[2.8125rem] shrink-0" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const styles = tv(
// TODO: this is a workaround to align, but need to find a better way.
popover: 'w-full',
// icon: 'text-primary transition-transform',
iconWrapper: 'mb-[-0.4rem] flex flex-shrink-0 items-center text-primary',
iconWrapper: 'pointer-events-none mb-[-0.4rem] flex flex-shrink-0 touch-none items-center text-primary',
textWrapper: 'flex flex-shrink items-center overflow-hidden pr-2',
},
variants: {
Expand Down

1 comment on commit 2df41f7

@vercel
Copy link

@vercel vercel bot commented on 2df41f7 Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

gel-next-site – ./apps/site

gel-next-site-git-main-westpacgel.vercel.app
gel-next-site.vercel.app
gel-next-site-westpacgel.vercel.app

Please sign in to comment.