Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accordion Open and Close Transistion #149

Closed
justinspencer opened this issue Oct 18, 2023 · 2 comments · Fixed by #161
Closed

Accordion Open and Close Transistion #149

justinspencer opened this issue Oct 18, 2023 · 2 comments · Fixed by #161
Assignees
@samithaf @tomjackking
Labels
bug Something isn't working

Comments

@justinspencer
Copy link
Collaborator

The open and close transition on the Accordion fades the content while the item is opening or closing. This leads to an overlap of content during the animation which is incorrect. See screen grab attached.

The preferred action is to mask the containing content as shown in the current GEL implementation. See screen grab attached.

Not correct Correct
@justinspencer justinspencer added the bug Something isn't working label Oct 18, 2023
@tomjackking tomjackking mentioned this issue Oct 19, 2023
Merged
@tomjackking tomjackking linked a pull request Oct 19, 2023 that will close this issue
fixes/issue 149 #161
Merged
@samithaf
Copy link
Collaborator

@justinspencer please retest and open the issue if it's still not fixed.

@samithaf samithaf reopened this Oct 24, 2023
@samithaf
Copy link
Collaborator

@jaortiz I just reopened the original issue.

@jaortiz jaortiz mentioned this issue Oct 24, 2023
Merged
samithaf added a commit that referenced this issue Oct 24, 2023
@samithaf
Merge pull request #196 from WestpacGEL/fix/#149-accordion
109343c 
fix(accordion): fix open and close animation
@jaortiz jaortiz closed this as completed Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samithaf samithaf

@tomjackking tomjackking

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes/issue 149 WestpacGEL/GEL-next
4 participants
@justinspencer @samithaf @jaortiz @tomjackking