Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes/issue 149 #161

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fixes/issue 149 #161

merged 1 commit into from
Oct 19, 2023

Conversation

tomjackking
Copy link
Collaborator

fixes #149

  • fixed issue with accordion animation when opening/closing an item
  • matched animation on accordion expanded icon to current GEL (no animation)

@tomjackking
- fixed issue with accordion animation
eb3e89f 
- matched animation on accordion expanded icon to current GEL (no animation)
@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023

⚠️ No Changeset found

Latest commit: eb3e89f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
gel-next-storybook ✅ Ready (Inspect) Visit Preview Oct 19, 2023 4:35am

This was linked to issues Oct 19, 2023
Accordion Open and Close Transistion #149
Closed
Alert text wrapping and icon clipping #150
Closed
@tomjackking tomjackking removed a link to an issue Oct 19, 2023
Alert text wrapping and icon clipping #150
Closed
@kenjishiromajp kenjishiromajp merged commit d33fa16 into develop Oct 19, 2023
4 checks passed
@kenjishiromajp kenjishiromajp deleted the fixes/issue-149-accordion-transition branch October 19, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjishiromajp kenjishiromajp kenjishiromajp approved these changes

@samithaf samithaf Awaiting requested review from samithaf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accordion Open and Close Transistion
2 participants
@tomjackking @kenjishiromajp