Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover placement #177

Closed
justinspencer opened this issue Oct 23, 2023 · 2 comments · Fixed by #237
Closed

Popover placement #177

justinspencer opened this issue Oct 23, 2023 · 2 comments · Fixed by #237
Assignees
@samithaf @tomjackking
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@justinspencer
Copy link
Collaborator

In GEL 2.0 (link below) logic was applied to ensure that the popover always fitted in the viewport on all devices. For some reason this was not added in GEL 3.0

GEL 2.0 Popover
https://gel.westpacgroup.com.au/GUI/WBC/popovers/#popovers

Popover Demo
https://gel.westpacgroup.com.au/GUI/WBC/examples/popovers/2.1.1/ex1/demo/?v=0.8.1

Popover positioning
@justinspencer justinspencer added the enhancement New feature or request label Oct 23, 2023
@justinspencer
Copy link
Collaborator Author

This is an example of how the popover used to work. Notice how the position of the popover (and the arrow) is adjusted to accommodate the viewport size.

Smart.Popovers.2.mov

@tomjackking tomjackking self-assigned this Oct 24, 2023
@samithaf samithaf added the good first issue Good for newcomers label Oct 24, 2023
@tomjackking tomjackking linked a pull request Nov 1, 2023 that will close this issue
Enhancement/popover location #237
Merged
@samithaf
Copy link
Collaborator

samithaf commented Nov 3, 2023

@justinspencer please check the latest and it's fixed

@samithaf samithaf closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samithaf samithaf

@tomjackking tomjackking

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
GEL Tech Upgrade
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhancement/popover location WestpacGEL/GEL-next
3 participants
@justinspencer @samithaf @tomjackking