Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/popover location #237

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Enhancement/popover location #237

merged 4 commits into from
Nov 2, 2023

Conversation

tomjackking
Copy link
Collaborator

  • added enhancement so popover will stay on screen unless placement of top or bottom is specified

Copy link

changeset-bot bot commented Nov 1, 2023

⚠️ No Changeset found

Latest commit: 296e0ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gel-next-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 3:17am
gel-next-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 3:17am

@samithaf
Copy link
Collaborator

samithaf commented Nov 1, 2023

I wonder, can we use this https://react-spectrum.adobe.com/react-aria/usePopover.html#flipping

Another suggestion by library author can be found here, adobe/react-spectrum#5341

Updated Note on popover component page to TODO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popover placement
2 participants