Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#80: gel docs update #172

Merged
merged 12 commits into from
Oct 23, 2023
Merged

Feature/#80: gel docs update #172

merged 12 commits into from
Oct 23, 2023

Conversation

kenjishiromajp
Copy link
Collaborator

Resolves #80

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 59166db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gel-next-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 5:40am

@kenjishiromajp kenjishiromajp linked an issue Oct 23, 2023 that may be closed by this pull request
Gel docs update #80
Closed
samithaf
samithaf reviewed Oct 23, 2023
View reviewed changes
packages/ui/package.json
@@ -104,6 +108,7 @@
"prettier": "^2.8.4",
"prop-types": "^15.8.1",
"react": "^18.2.0",
"react-docgen-typescript": "~2.2.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lib needs to be dev dependancy. Please check any other dependancies as well.. We have added them as dependancies for no reason.

@samithaf samithaf merged commit 4dc0704 into develop Oct 23, 2023
4 checks passed
@samithaf samithaf deleted the feature/80-gel-docs-update branch October 23, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samithaf samithaf samithaf approved these changes

@jaortiz jaortiz Awaiting requested review from jaortiz

@tomjackking tomjackking Awaiting requested review from tomjackking

Assignees
No one assigned
Labels
None yet
Projects
GEL Tech Upgrade
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gel docs update
2 participants
@kenjishiromajp @samithaf