Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/articles home page #236

Merged
merged 11 commits into from
Nov 3, 2023
Merged

Feature/articles home page #236

merged 11 commits into from
Nov 3, 2023

Conversation

kenjishiromajp
Copy link
Collaborator

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: d2b6454

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gel-next-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 6:15am
gel-next-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 6:15am

samithaf
samithaf reviewed Nov 1, 2023
View reviewed changes
packages/ui/src/components/grid/components/container/container.styles.ts Outdated
@@ -2,7 +2,7 @@ import { tv } from 'tailwind-variants';

export const styles = tv(
{
base: 'mx-auto box-border w-full max-w-container px-2 xsl:px-5 sm:px-6 md:px-8 lg:px-10',
base: 'mx-auto box-border w-full max-w-container px-4 xsl:px-5 sm:px-6 md:px-8 lg:px-10',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaortiz is this change going to collide with grid changes you are working?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it will as current GEL grid has default padding-x of 12px. @kenjishiromajp are you not able to just override that padding for your use case?

@samithaf samithaf merged commit f5bf59d into develop Nov 3, 2023
5 checks passed
@samithaf samithaf deleted the feature/articles-home-page branch November 3, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samithaf samithaf samithaf approved these changes

@jaortiz jaortiz Awaiting requested review from jaortiz

@tomjackking tomjackking Awaiting requested review from tomjackking

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjishiromajp @samithaf @jaortiz