Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes/menu and missing content #457

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Fixes/menu and missing content #457

merged 3 commits into from
Dec 6, 2023

Conversation

tomjackking
Copy link
Collaborator

  • updated top level menu item order
  • added some missing pages to the content section in design-system

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7d66334

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gel-next-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 10:09pm
gel-next-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 10:09pm

samithaf
samithaf reviewed Dec 6, 2023
View reviewed changes
.../content/design-system/content/guidelines/third-party-websites/design/undefined/content.mdoc Outdated
@@ -0,0 +1,7 @@
Use hyperlinks to third-party website pages.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path has "undefined" is this right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This leads to pretty bad content author experience as well. cc. @jaortiz @kenjishiromajp

Screenshot 2023-12-07 at 8 11 41 am

@samithaf samithaf merged commit e0e37ce into develop Dec 6, 2023
8 checks passed
@samithaf samithaf deleted the fixes/menu-and-missing-content branch December 6, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samithaf samithaf samithaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomjackking @samithaf