Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade prettier config #734

Merged
merged 12 commits into from
Feb 27, 2024
Merged

upgrade prettier config #734

merged 12 commits into from
Feb 27, 2024

Conversation

kenjishiromajp
Copy link
Collaborator

@kenjishiromajp kenjishiromajp commented Feb 21, 2024

  • upgrading prettier
  • fixing interfaces errors due to upgrading sub packages.

OBS:
The main fix was that, new react-aria package is using WeakMap and the key to get and set the value of the state (for instance useRadio) is the reference of state variable itself, when we were using state = { ...state, look, orientation} the reference of the state is lost because we are creating another object with a spread function and therefore it was causing undefined...

Copy link

changeset-bot bot commented Feb 21, 2024

🦋 Changeset detected

Latest commit: 579e46b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@westpac/eslint-config Minor
protoform Patch
site Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gel-next-protoform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 7:37am
gel-next-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 7:37am
gel-next-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 7:37am

@kenjishiromajp kenjishiromajp marked this pull request as draft February 21, 2024 05:29
@jaortiz jaortiz merged commit a5422d2 into develop Feb 27, 2024
9 checks passed
@jaortiz jaortiz deleted the feature/upgrade-prettier-config branch February 27, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants