Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Homeworld 3. #44

Merged
merged 2 commits into from
May 20, 2024
Merged

Add Homeworld 3. #44

merged 2 commits into from
May 20, 2024

Conversation

MetaRossi
Copy link
Contributor

Add the Steam game Homeworld 3. Works really well. Possibly due to being an Unreal Engine 4 game.

@MetaRossi
Add Homeworld 3.
18297a8
@MetaRossi
Forgot to run linter.
cf6827f 
Moved Steam link template to bottom of the file.
danielkorkin

This comment was marked as outdated.

Sign in to view

@JoshuaBrest
Copy link
Contributor

JoshuaBrest commented May 19, 2024 •
edited
Loading

Make sure to add your game to /src/game-support/README.md

Please ignore this comment. This person is wrong.

JoshuaBrest
JoshuaBrest approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@JoshuaBrest JoshuaBrest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

src/game-support/hw-3.md Show resolved Hide resolved
danielkorkin
danielkorkin approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@danielkorkin danielkorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad I forgot we migrated away from storing the games in that file

@JoshuaBrest
Copy link
Contributor

My bad I forgot we migrated away from storing the games in that file

All good!!!!! (:

@IsaacMarovitz IsaacMarovitz merged commit 9c3fc25 into Whisky-App:main May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBrest JoshuaBrest JoshuaBrest approved these changes

@IsaacMarovitz IsaacMarovitz IsaacMarovitz approved these changes

@danielkorkin danielkorkin danielkorkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MetaRossi @JoshuaBrest @IsaacMarovitz @danielkorkin