Add 6 games; Precise contributing docs, especially "opens" flag requirements; fix typos #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaBrest
suggested changes
Jul 4, 2024
|
@JoshuaBrest all code review proposals are applied. |
|
Golden Just Cause 2 has been added. |
mattmaniak
changed the title
mattmaniak
changed the title
|
Add Deus Ex: Human Revolution - Director's Cut. |
|
Add Kholat title - silver. |
mattmaniak
changed the title
JoshuaBrest
suggested changes
Jul 8, 2024
hahayupgit
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposal is targeted to clarify the
opensflag which says whether a game "opens"... The issue I have found with it is that it was not clear if a game that crashes after 1, 5 or 10 seconds can be considered as "opening". Now a requirement to mark a game as "opening" is ability to launch it to it's default screen (the one that is loaded after launch without using any input) which is most often a main menu.I altered games mostly added by me with an updated
opensflag also.