fix: add max_spread param to router operations simulation #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerber0x
commented
Sep 3, 2024
| @@ -284,6 +284,7 @@ pub fn aggregate_fees( | |||
| msg: to_json_binary(&router::QueryMsg::SimulateSwapOperations { | |||
| offer_amount: balance, | |||
| operations: operations.clone(), | |||
| max_spread: Some(Decimal::percent(50u64)), | |||
There was a problem hiding this comment.
add new max_spread in simulation
kerber0x
commented
Sep 3, 2024
| @@ -365,7 +366,7 @@ pub fn forward_fees( | |||
| factory_addr: config.vault_factory.to_string(), | |||
| factory_type: FactoryType::Vault { | |||
| start_after: None, | |||
| limit: Some(30u32), | |||
| limit: Some(60u32), | |||
There was a problem hiding this comment.
increased limit to 60 items, as there are over 30 pools on terra atm.
kerber0x
commented
Sep 3, 2024
| // check max spread limit if exist | ||
| swap::assert_max_spread( | ||
| belief_price, | ||
| max_spread, | ||
| offer_asset.amount, | ||
| return_asset.amount.checked_add(fees)?, |
There was a problem hiding this comment.
fix for bug reported a while ago
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
==========================================
+ Coverage 93.21% 94.84% +1.63%
==========================================
Files 219 214 -5
Lines 24868 24770 -98
==========================================
+ Hits 23180 23493 +313
+ Misses 1688 1277 -411 ☔ View full report in Codecov by Sentry. |
kerber0x
commented
Sep 3, 2024
| // check max spread limit if exist | ||
| swap::assert_max_spread( | ||
| belief_price, | ||
| max_spread, | ||
| offer_asset.amount, | ||
| return_asset.amount.checked_add(fees)?, |
kerber0x
commented
Sep 3, 2024
| @@ -369,6 +374,16 @@ fn simulate_swap_operations( | |||
| }, | |||
| )?; | |||
|
|
|||
| if max_spread.is_some() && res.return_amount > Uint128::zero() { | |||
There was a problem hiding this comment.
So if the max_spread is passed and the return_amount is above zero then we can perform the spread assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
With the previous fix for failing fee aggregation it was introduced a simulation on the aggregation swap. However, the aggregation doesn't perform any spread assertions. This code introduces this into the pool router.
Related Issues
Checklist:
Update index.md)cargo fmt --all --.cargo clippy -- -D warnings.cargo schema.