This repository has been archived by the owner on Mar 26, 2024. It is now read-only.
When to worry about batching #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait, you said "a few hundred per minute" here, but 2-3 thousand per minute in the comment. If it happens at a few hundred, that seems pretty bad. 2-3k still seems worrying. @JoshRagem any idea how many you're sending? Feels like close to that. |
|
@waisbrot I'm not entirely sure when it does happen. We went from ~100/minute to ~2k, so not entirely sure where the limit is; so I figured it wouldn't hurt to be cautious in the README? |
|
@waisbrot you okay with merging in this doc change? |
|
I am, but see #29 for why I cannot. I haven't gotten a response there, so I'll start thinking about transitioning. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @waisbrot at #23 (comment)