Updates Fetch Online Data Example for Readability & Adds JavaDoc Comments #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds a list to seperate out each use-case adds throws and author
…single and multiple entities
opted to use the Qid search to be singular with hints of getting plural resutls opted to use the byTitle section to example getting with multiple titles to search and hints of getting singular results
- adds optional o/p to maintain minimum change to original functionality - tighten up language for kind of Ent returned with the search functionality - prints the results of the search func to its own file
…cal file for local examination
|
That last commit adding the functionality to write the results to the results dir was intended to be a separate pull request. By default it is disabled to maintain the behavior of the example, it just allows digging into the results since they can't all be read in a console meaningfully. Happy to fix/exclude/remove that as you may see fit here, but I found it helpful when I was getting familiar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Been using this repo for a personal project and noticed that this example was a little bit lacking. I am a newbie to this toolkit so I'm approaching this with that naiveté - but wanted to propose these changes :)
Let me know!