Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a few minor changes regarding search result display #1006

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

erinz2020
Copy link
Contributor

@erinz2020 erinz2020 commented Feb 4, 2025

update some translations, and search result display in jsp header

PR does not fix any numbered issue.

@erinz2020 erinz2020 requested a review from naknomum February 4, 2025 13:55
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 0.13%. Comparing base (bc71c9f) to head (e216bd3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ontend/src/components/header/HeaderQuickSearch.jsx 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              main   #1006      +/-   ##
==========================================
- Coverage     0.13%   0.13%   -0.01%     
  Complexity      29      29              
==========================================
  Files          580     580              
  Lines        64015   64020       +5     
  Branches     11090   11092       +2     
==========================================
  Hits            89      89              
- Misses       63907   63912       +5     
  Partials        19      19              
Flag Coverage Δ
backend 0.13% <0.00%> (-0.01%) ⬇️
frontend 0.13% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erinz2020 erinz2020 marked this pull request as draft February 4, 2025 16:39
@erinz2020 erinz2020 self-assigned this Feb 4, 2025
@erinz2020 erinz2020 marked this pull request as ready for review February 4, 2025 19:31
@erinz2020 erinz2020 marked this pull request as draft February 5, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants