-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index MediaAssets in OpenSearch #1014
Draft
naknomum
wants to merge
8
commits into
main
Choose a base branch
from
912_mediaasset_in_opensearch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+155
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1014 +/- ##
=======================================
Coverage 0.13% 0.14%
- Complexity 29 30 +1
=======================================
Files 580 580
Lines 64015 64075 +60
Branches 11090 11094 +4
=======================================
+ Hits 89 91 +2
- Misses 63907 63965 +58
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index MediaAssets in OpenSearch
PR fixes #912
Due to the fact that the Base.java class (which search is built on) requires
getId()
of the implementing class to be overridden and return a String -- and thanks to a questionable decision to have the primary key id in MediaAsset to be anint
-- I had to do a little slight-of-hand.int getIdInt()
now has replaced the originalgetId()
in MediaAsset.java;getId()
returns the String (of the int id).All code which used to call
getId()
but requires an int, has been modified. A surprisingly huge amount of the code was just fine withgetId()
being left as-is and returning a String: most of these were just being used inside other Strings, jsp output, debugging statements, and the like.Best attempt was made to find all the substitutions in jsp files (as there would be no compilation warnings there). Spot checks on running jsp pages could not find any missed. However, this branch should be tested thoroughly on QA before merging. For that reason, it will be left a DRAFT until further testing and code review.