Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login docker securely #696

Merged
merged 10 commits into from
Sep 5, 2024
Merged

Login docker securely #696

merged 10 commits into from
Sep 5, 2024

Conversation

tsubramanian
Copy link
Contributor

secret passed securely as parameter

Login the docker securely according to the news / incidents reported : https://it.slashdot.org/story/24/08/17/056242/github-actions-artifacts-leak-tokens-expose-cloud-services-and-repositories

Changes

  • [bullet list include any model updates]
  • [new or edited functions]
  • [significant changes to UX]
  • [design decisions, especially if architectural patterns are new/altered]
  • [can use text, screenshots, or files]
  • [a callout of any ##TODO or ##FIXMEs found/created as part of the fix]

Copy link
Member

@TanyaStere42 TanyaStere42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lines up with docs for actions update and secrets management

@TanyaStere42 TanyaStere42 merged commit d932938 into master Sep 5, 2024
1 check passed
@TanyaStere42 TanyaStere42 deleted the docker-login-secure branch September 5, 2024 21:58
Rodhlann pushed a commit to Rodhlann/Wildbook that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants