fix google map key issue #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holmbergius
added a commit
that referenced
this pull request
Sep 6, 2024
fix google map key issue # Conflicts: # frontend/src/locale/de.json # frontend/src/locale/en.json # frontend/src/locale/es.json # frontend/src/locale/fr.json # frontend/src/locale/it.json
Rodhlann
pushed a commit
to Rodhlann/Wildbook
that referenced
this pull request
Dec 6, 2024
fix google map key issue
Rodhlann
pushed a commit
to Rodhlann/Wildbook
that referenced
this pull request
Dec 6, 2024
fix google map key issue # Conflicts: # frontend/src/locale/de.json # frontend/src/locale/en.json # frontend/src/locale/es.json # frontend/src/locale/fr.json # frontend/src/locale/it.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix an issue on map page: changed state(key) did not trigger third party component(react google map) re-rendering, thus map was not updated with key from property files, so map always showed "development use only". updated code will fix this issue. now if key is null(initial value), show a loading status instead of map
PR does not fix a numbered issue