Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matchingSet built using OpenSearch #993

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Conversation

naknomum
Copy link
Member

@naknomum naknomum commented Jan 24, 2025

refactor to use OpenSearch (on Annotations) to building matching set

PR fixes #872

  • getMatchingSetQuery() to build actual OpenSearch query (optionally based on taskParams to support legacy compatibility)
  • getMatchingSet() returns actual annotations from OpenSearch results, using a query from above
  • removal of (db-based) matchingSet methods which are replaced or not longer needed
  • a few more fields indexed for searching in annotations: encounterUserUuid, encounterProjectIds, matchAgainst

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 205 lines in your changes missing coverage. Please review.

Project coverage is 0.13%. Comparing base (bc71c9f) to head (238fe75).

Files with missing lines Patch % Lines
src/main/java/org/ecocean/Annotation.java 0.00% 157 Missing ⚠️
src/main/java/org/ecocean/Encounter.java 0.00% 22 Missing ⚠️
...c/main/java/org/ecocean/ia/plugin/WildbookIAM.java 0.00% 14 Missing ⚠️
src/main/java/org/ecocean/OpenSearch.java 0.00% 11 Missing ⚠️
...c/main/java/org/ecocean/identity/IAQueryCache.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              main    #993      +/-   ##
==========================================
- Coverage     0.13%   0.13%   -0.01%     
  Complexity      29      29              
==========================================
  Files          580     580              
  Lines        64015   64019       +4     
  Branches     11090   11085       -5     
==========================================
  Hits            89      89              
- Misses       63907   63911       +4     
  Partials        19      19              
Flag Coverage Δ
backend 0.13% <0.00%> (-0.01%) ⬇️
frontend 0.13% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match Set to pull from opensearch
2 participants