convert useEffect dependencies from array to string

WildMeOrg · Nov 3, 2023 · 174bbb3 · 174bbb3
1 parent d062293
commit 174bbb3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 225 deletions.
diff --git a/src/AuthenticatedSwitch.jsx b/src/AuthenticatedSwitch.jsx
@@ -7,7 +7,6 @@ import AuthenticatedAppHeader from './components/AuthenticatedAppHeader';
 import SaveCustomField from './pages/fieldManagement/settings/saveField/SaveField';
 import GeneralSettings from './pages/generalSettings/GeneralSettings';
 import SiteStatus from './pages/siteStatus/SiteStatus';
-import SplashSettings from './pages/splashSettings/SplashSettings';
 import FieldManagement from './pages/fieldManagement/FieldManagement';
 import UserManagement from './pages/userManagement/UserManagement';
 import AdminActions from './pages/adminActions/AdminActions';
@@ -100,9 +99,6 @@ export default function AuthenticatedSwitch({
                     <SiteSetup />
                   ) : (
                     <Switch location={location}>
-                      <Route path="/settings/front-page" exact>
-                        <SplashSettings />
-                      </Route>
                       <Route path="/settings/front-page/preview">
                         <Splash />
                       </Route>

diff --git a/src/pages/reportSighting/ReportForm.jsx b/src/pages/reportSighting/ReportForm.jsx
@@ -137,7 +137,7 @@ export default function ReportForm({
     useState({});
 
   useEffect(() => {
-    if (sightingFieldSchemas.length === 0) return;
+    console.log('>>>>>>>>>>>>>');
     const initialDefaultSightingFormValues = getInitialFormValues(
       defaultSightingSchemas,
     );
@@ -155,12 +155,12 @@ export default function ReportForm({
     setEncounterFormValues(initialDefaultEncounterFormValues);
     setCustomEncounterFormValues(initialCustomEncounterFormValues);
   }, [
-    customEncounterSchemas,
-    customSightingSchemas,
-    defaultEncounterSchemas,
-    defaultSightingSchemas,
-    sightingFieldSchemas,
-    encounterFieldSchemas,
+    customEncounterSchemas.join('-'),
+    customSightingSchemas.join('-'),
+    defaultEncounterSchemas.join('-'),
+    defaultSightingSchemas.join('-'),
+    sightingFieldSchemas.join('-'),
+    encounterFieldSchemas.join('-'),
   ]);
 
   const requiredDefaultSightingSchemas =
@@ -275,7 +275,7 @@ export default function ReportForm({
   } = usePostAssetGroup();
 
   const submitReport = async () => {
-    checkRequired();
+    // checkRequired();
     if (formValid) {
       const report =
         sightingType === 'one'

diff --git a/src/pages/splashSettings/SplashSettings.jsx b/src/pages/splashSettings/SplashSettings.jsx