Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't auto-skip hidden files #647

Closed
wants to merge 2 commits into from

Conversation

nimrodkor
Copy link
Contributor

Hello again!

I tried to look at a diff on a GHA yaml, in the regular place - .github/workflows/whatever.yaml, and couldn't get it with difftastic.

Apparently, the walkdir filtered them out... This fixes it!

@poliorcetics
Copy link
Contributor

I looked at issues but not PRs, I should have 😅 I just opened #654.

Compared to your PR, it adds a test and also does not call .standard_filters() (which is by definition the default and unnecessary here)

@nimrodkor
Copy link
Contributor Author

Very nice @poliorcetics !
I really don't mind what gets merged, if @Wilfred prefers your PR with the test - feel free to close this one.
Just mind the fact your PR has conflicts...

@poliorcetics
Copy link
Contributor

Just mind the fact your PR has conflicts...

Thanks for the notif, updated 👍

@nimrodkor
Copy link
Contributor Author

nimrodkor commented Mar 17, 2024

Closing for another PR

@nimrodkor nimrodkor closed this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants