-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #7: provide tutorial #31
Conversation
First three chapters. Tested locally. Signed-off-by: Matteo Cafasso <[email protected]>
Reorganised index tree. Signed-off-by: Matteo Cafasso <[email protected]>
Signed-off-by: Matteo Cafasso <[email protected]>
Signed-off-by: Matteo Cafasso <[email protected]>
Added events triggering sequence in plugins. Added few dependencies to installation. Signed-off-by: Matteo Cafasso <[email protected]>
Signed-off-by: Matteo Cafasso <[email protected]>
Move to alabaster theme. Add fork on GitHub banner. Updated version and copyright year. Signed-off-by: Matteo Cafasso <[email protected]>
Signed-off-by: Matteo Cafasso <[email protected]>
Signed-off-by: Matteo Cafasso <[email protected]>
Last chapter has been added. PR in review. |
Signed-off-by: Matteo Cafasso <[email protected]>
When i tried to generate the documentation with
I don't know if they are relevant, yet you might want to fix them. |
Signed-off-by: Matteo Cafasso <[email protected]>
removed the unused installation.rst file |
@Wenzel any further comment? Shall I merge? |
My comments for the Installation section:
It should be at the end of this section, when the user has indeed tried to install
|
1,2,3 will fix. 4: The python package is the correct way to install SEE. It's up to the user to choose how and where to install the package. The tutorial is about the framework not how to set up a generic development environment. Docker in particular, does not play well with SEE. 5: the commands are equivalent, I'd rather stick to the one already used in the documentation. 6: the fact that you never had to load KVM in an OS doesn't mean it's loaded by default on all the distributions. The command will exit with 0 if the loading was successful or it was already loaded, it will prompt an error if KVM is not supported by the HW. |
Also in the Plugins and Protocols section:
That's all, you can merge it 👍 |
@Wenzel it seems the "previous"/"next" links are not supported by the theme. I'll see if I can somehow workaround this. |
Signed-off-by: Matteo Cafasso <[email protected]>
Signed-off-by: Matteo Cafasso <[email protected]>
Seems only supported way atm is via side bar: http://alabaster.readthedocs.io/en/latest/customization.html#variables-and-feature-toggles |
First three chapters.
Tested locally.
Signed-off-by: Matteo Cafasso [email protected]